Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blaine & Roshni Adagrams #27

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

roshni-patel
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? A parameter, method signature, argument, could have a block, output/return.
What are the advantages of using git when collaboratively working on one code base? Remote working, easier collaboration
What kind of relationship did you and your pair have with the unit tests? Tumultuous, enlightening
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used map and sum but earlier we had tried to use other methods such as max_by and each_with_index.
What was one method you and your pair used to debug code? We printed output, rubberducking, and we asked for help over Slack.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We had similar knowledge gaps when it comes to working with hashes. Our rubberducking and talking through our approaches was very helpful. It was a good pairing and we both learned a lot and a big part of what was helpful was being able to own what we didn't know and seek help when we needed it.

Copy link
Collaborator

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you hit all the learning goals here. Well done.

Comment on lines +1 to +2
# Creates an array of letters based on the quantity of letters given
def letters_arr(letters)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +12 to +13
# Generates a letters array using previous method and selects 10 random letters
def draw_letters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +61 to +62
# Verifies that what cards player played were in their hand
def uses_available_letters?(play, deck)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +73 to +75
# Scores the word the player played
# Factors in bonus points
def score_word(word)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +113 to +115
# Produced the highest score in the game
# Takes into account ties and exceptions (10 letter words)
def highest_score_from(words)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants