Fire - Noor and Anna #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 23, 2020
Comment on lines
+4
to
+5
| .floo | ||
| .flooignore |
| @@ -0,0 +1,129 @@ | |||
|
|
|||
| LETTERS = { | |||
There was a problem hiding this comment.
Nice way to set up the distribution of letters.
| } | ||
|
|
||
| # WAVE 1 | ||
| def draw_letters() |
|
|
||
| # WAVE 2 | ||
|
|
||
| def uses_available_letters?(input, letters_in_hand) |
|
|
||
| # Wave 3 | ||
|
|
||
| def score_word(word) |
| return hash | ||
| elsif length < 10 | ||
| min_length = word_lengths.min | ||
| hash[:word] = words[word_lengths.index(min_length)] |
There was a problem hiding this comment.
This might not work in all cases. What if there is a non-winning word with an equal length
There was a problem hiding this comment.
Ah I see! Because we are checking through all the words that are passed as an argument, when we should be looking at the subset that has the highest points - is that right?
Comment on lines
+113
to
+115
| hash[:word] = words[word_lengths.index(length)] | ||
| hash[:score] = points[word_lengths.index(length)] | ||
| return hash |
There was a problem hiding this comment.
You don't know if the word with length 10 is tied for the highest score here.
|
|
||
| # Wave 4 | ||
|
|
||
| def highest_score_from(words) |
There was a problem hiding this comment.
I am uncertain that this method will work in all cases. See my comments below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
Enumerablemixin? If so, where and why was it helpful?