Branches-Stephanie Garcia

[Steph0088]

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	It was difficult to have to think about how to create a program from scratch because I am still having trouble understanding how classes interact. One of the biggest design challenges what each class would be responsible for.
What was a design decision you made that changed over time over the project?	At first I thought I would need a room class and then I found Iike the design that was given because it was more straightforward.
What was a concept you gained clarity on, or a learning that you'd like to share?	The truth I don’t really think I gained clarity on anything. That sounds negative but what I mean is that the opposite happened. I think I realized how much I don’t understand, but I think that is a good thing. I know what I am struggling with specifically and what I have to ask questions and get help on. Overall, I know the concepts that are taking me longer to understand.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	The test in my concierge that checks to see if rooms actually returns a rooms array. It is nominal because it is just checking to see if it is an array object.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	When I check to make sure that a start date and end date were inputed. It makes it an edge case because it is checking to see if the user even entered a value.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I think pseudocode is super helpful, because it helps you get organized and though I want to say that writing tests was helpful for me, they weren’t. I understand the importance of it and I one day want to be able to write tests, but I struggled so much and got so stuck on my tests that it really kept me from moving forward. I am hoping that one day I will conquer tests, but write now they are just a pain in the ass. That being said I like the way we are being taught to do it this way. I am just a slow learner.

[tildeee]

Hotel

What We're Looking For

Test Inspection

Workflow	yes / yes but no test / no
Wave 1
List rooms	yes
Reserve a room for a given date range	yes
Reserve a room (edge case)	yes, but no test-- in your implementation, you raise an error if there are no available rooms, but there's no test to verify that!
List reservations for a given date	yes
Calculate reservation price	yes but no test
Invalid date range produces an error	yes
Test coverage	yes, mostly
Wave 2
View available rooms for a given date range	yes but needs more tests
Reserving a room that is not available produces an error	yes, but no test
Test coverage	not there yet
Wave 3
Create a block of rooms
Check if a block has rooms
Reserve a room from a block
Test coverage

Code Review

Baseline	Feedback
Used git regularly	yes
Answer comprehension questions	yes! I feel you + you are valid!
Design
Each class is responsible for a single piece of the program	yes
Classes are loosely coupled	yes
Fundamentals
Names variables, classes and modules appropriately	yes
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	we could see more of this
Understands the differences between class and instance methods	yes
Appropriately uses iterators and Enumerable methods	each loops were great! It'd be great to see more of this in future projects
Appropriately writes and utilizes classes	yes
Appropriately utilizes modules as a namespace	yes
Wrap Up
There is a refactors.txt file	nope
The file provides a roadmap to future changes	nope

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

Your existing code is good. It is logical and in good code style. Also, with the tests that I see here, your tests are set up correctly (with the right logic for Arrange, Act, and Assert). Overall, I think that the code we see here is definitely on the right track! With the existing code that works, there's very little I would change besides make some tests more specific.

As unit 1 closes, we will see in unit 2 that tests stick around. We won't re-inforce TDD as much, so I hope that you find your rhythm in figuring out what works best for you; how much implementation code can you write without TDD. My hope is that eventually, writing tests will be a comfortable way of shaping what your code's goals are and how to check they're correct.

I really hope that when we meet to talk some time, we can talk about which specific parts of Ruby code we want to target our learning on-- Personally, I want to know if it's all tests, or if there's more topics for us to cover!

In general, this project's implementation code is successful; its tests didn't cover a lot of what I expect it to cover. That being said, I'm proud of what the existing code represents: I feel great about your use of variables, methods, and classes, and it will only get better!