Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Caroline #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

stupendousC
Copy link

Might come back with DFS version, but then again, might not...

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall well done, I just have one comment on semantics rather than the solution itself. Pretty good example of using DFS to solve the problem.

dislikes[currDog].each do |enemy|
if visited[enemy].nil?
visited[enemy] = newColor
queue << enemy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're shoveling and popping things from the same end, so this is really a stack instead of a queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants