Janice H. #13
Open
Janice H. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 10, 2020
There was a problem hiding this comment.
I think, the reason your code isn't working is that you add each node to the queue regardless of the order you encounter the nodes. I think you should only add them to the queue if the queue is empty and you haven't reached them yet. You can also take a look at my solution branch on the repo as well now.
|
|
||
| while !graph_queue.empty? | ||
| current = graph_queue.shift | ||
| if !searched.include?(current) |
There was a problem hiding this comment.
I would suggest using a hash with the key being the node and the color being the value. Then you can do unless searched[current].nil?
Comment on lines
+12
to
+14
| dislikes.each_with_index { |enemies, dog| | ||
| graph_queue << dog | ||
| } |
There was a problem hiding this comment.
Instead of adding each node to the Queue in the beginning, maybe make that while loop below do something like this:
dislikes.each_with_index do |enemies, dog|
unless searched[dog] # make searched a hash
graph_queue << dog
current_color = # whatever starting color you're on
while !graph_queue.empty?
# Then your code continues with your while loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't get that darn test 4! I know it's because when a node is neither color it defaults to one, so those ones are ending up with the same color, which later isn't allowed. Hmm.