Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KariSem VideoStore (Karis and Semret) - Edges #9

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

snicodimos
Copy link

@snicodimos snicodimos commented Dec 20, 2018

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C10/VideoStoreConsumer-API#7
For each person in your pair, describe something you learned from your partner during this project Semret: I learned a lot of cool CSS tricks. Through our conversations things I was unclear of in terms of props and states is now much clearer. WONDERFUL HUMAN!! Karis: I got a better understanding of using both Rails and React. Semret showed me how to do a lot of the passing in state and it was AMAZING!
What was one area of React you gained more clarity on during this assignment? Passing of objects through callback, the ability to use a component even if its not nest. For instance, we were able to use Video component in the search component even thought they were siblings not nested with each other.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content Using a Video component and making a video collection component that kept track of the list.
Describe how you handled rentals with React We did a post request to the Rails API. To get the info of selected customer and video we utilized even hander in each components (video and customer components) to pass the message to the library and then do a post request. We also had to create a due date 7 days from today in order to satisfy the requirements for the rails post request.
Describe a DOM event your application handled All the click events such as rentals (checkout button), adding to library, selecting movie and customers for rentals
Did you use any functional stateless components? What for? No all of our components are classes but in retrospect we could have changed both customer and video components to functional components.
Did you use any container components? What for? Yes we did. We used videoCollection and CustomerCollection to put all the collection of items to be rendered when in library when a click happens.
Do you have any recommendations on how we could improve this project for the next cohort? Its good as is.

snicodimos and others added 30 commits December 17, 2018 16:22
…wing to the user. did this by putting the routes in a section and the buttons in the header
…m all in a list and used flex to make it into a row
… not selected. rn if both is unselected then it only shows the error msg for movie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants