Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Val & Michelle - Edges - Vambuster Videos #3

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

valgidzi
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C10/VideoStoreConsumer-API#3
For each person in your pair, describe something you learned from your partner during this project We have very similar workflows, so a lot of the project felt like we were sharing a brain. But we learned different Trello organization tips from each other that we really enjoyed.
What was one area of React you gained more clarity on during this assignment? Michelle learned that you don't need to place API calls in componentDidMount if an event is triggering the call. Val learned more about how a React front-end interacts with a Rails API back-end.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We have a Movie component, that renders in both MovieSearchForm component list and Library component list. Using props buttonText and callback, we could pass in different data to render Movie differently depending on the list.
Describe how you handled rentals with React When the individual rental selection buttons are clicked, it changes the state in App. When the checkout rental button is clicked, it creates a new Rental via a post request to the Rails API.
Describe a DOM event your application handled When a user types into the text form, the onInputChange event handler reflects the DOM changes in state.
Did you use any functional stateless components? What for? The Movie, Customer, and Selection components are functional stateless components, because they didn't require state and only contain presentation logic.
Did you use any container components? What for? Library/MovieSearchForm and Customers are container components for Movie and Customer, respectively. We did this to DRY up our code.
Do you have any recommendations on how we could improve this project for the next cohort? The image_url bug felt like we were spending time on something that wasn't a learning goal, but other than that it was a pretty good project.

valgidzi and others added 30 commits December 18, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants