Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layla & Hayden - Edges - Video Store Consumer #11

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

lbristol88
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C10/VideoStoreConsumer-API#11
For each person in your pair, describe something you learned from your partner during this project Layla: I learned to never terminate running servers by clicking the x or closing tabs in terminal. It's better to use control C to end them because sometimes the servers can still be running and cause issues. Hayden: I learned how to use the render prop in React Router to render a component with props passed in instead of just rendering the component plain using the component prop!
What was one area of React you gained more clarity on during this assignment? Integrating external libraries with react, specifically react router and client side routing.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We had a type prop on the movie component that signified which container it belonged to (search vs library) and how to properly render itself.
Describe how you handled rentals with React We had all the necessary data (movie title, customer id) passed as props to NewRental component based on which movie and customer were currently selected, then simply attached an onClick callback to the submit button that triggered an axios post request with a url generated by string interpolating the necessary props. We also generated a due date within the submitNew function!
Describe a DOM event your application handled The search bar contained the onSubmit form so that the user can type in a movie and upon click, the search container displays all of the results through the searchMovieByTitle function.
Did you use any functional stateless components? What for? Yes, the NavBar is a functional component because there was no need for it to track state as it is only a list of three links.
Did you use any container components? What for? Yes, we had library and search containers. The library container, in particular, allowed for rendering both lists of customers and lists of movies based on a type prop passed to it. These components also held all of their respective child components (movie / customer) within their state.
Do you have any recommendations on how we could improve this project for the next cohort? Hayden - "i want to say yall should fix the bug in the api or at least tell us there might be a bug but honestly i also really enjoyed the disgusting treasure hunt and found it to be a great learning/debugging experience. maybe leave the bug in there lol"

lbristol88 and others added 27 commits December 18, 2018 09:53
can now add searched movie to library
added router functions to app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants