Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maddie Shields - Edges - reverse_words #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion lib/reverse_words.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,44 @@
# A method to reverse each word in a sentence, in place.
def string_reverse(my_string, beginning, ending)
front_index = beginning
back_index = ending

while front_index < back_index
front_value = my_string[front_index]
back_value = my_string[back_index]

my_string[front_index] = back_value
my_string[back_index] = front_value

front_index += 1
back_index -= 1
end
end

def reverse_words(my_words)
raise NotImplementedError
return if my_words == nil

i = 0
length = my_words.length

while i < length
while my_words[i] == ' ' && i < length
i += 1
end

beginning = i

while my_words[i] != ' ' && i < length
i += 1
end

ending = i - 1

string_reverse(my_words, beginning, ending)
end
return my_words
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: since you're manipulating the string in place, you don't need to return my_words on line 39. Line 39 could simply be return.

# time complexity: O(n) - goes through the loop n times, in this case it is through the length of my_words

# space complexity: O(1) - the storage doesn’t grow with the size of the input, stays constant with the length of the string