Dionisia Edges reverse_words #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 14, 2018
| my_words_start = index | ||
| my_words_end = index | ||
| end | ||
| end |
There was a problem hiding this comment.
Thought for further improvement: With the last test case scenario " evol ", your algorithm does work because for the first 4 spaces, on line 17 my_words_start will end up being greater than my_words_end. Can you intentionally add consideration for preceding and trailing consecutive white spaces?
shrutivanw
reviewed
Nov 14, 2018
lib/reverse_words.rb
Outdated
| my_words_end = index | ||
| end | ||
| end | ||
| return my_words |
There was a problem hiding this comment.
Since you're manipulating my_words in place, you don't need to return my_words. Line 28 could simply be return.
|
Nice work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time complexity is O(n). I have an index loop that goes through the whole string and within that loop, each word has the letters swapped.
Space complexity is O(1) because I only have 4 variables regardless of the size of the input: my_words_start, my_words_end, index and temp.