Amanda Ungco- Reverse Words #29
Conversation
| while string[i] != " " && i < string.length | ||
| i += 1 | ||
| end | ||
| space = i |
There was a problem hiding this comment.
Minor: you could simply return i and don't need to create another variable called space in this method.
| j = 0 | ||
| else j = space - 1 | ||
| end | ||
| my_words[i..j] = string_reverse(my_words[i..j]) |
There was a problem hiding this comment.
As we saw in class, in the first few slides of https://drive.google.com/file/d/0B__DV26QHsH4bWJmS1A0QXBad1U/view?usp=sharing, the substring method e.g. my_words[i..j] creates a new string object. As a result, you will end up using more space and your string manipulations are not happening in-place.
Slack me if you have further questions on this.
|
Although your string_reverse method is doing the string manipulation in-place, your reverse_words method is creating new string objects and manipulating those. Take a look at my solution at https://github.com/Ada-C10/reverse_words/blob/solution/lib/reverse_words.rb Do slack me if you have questions on any of this, and if needed, we could schedule a video call to discuss further. |
Time Complexity: O(n^2)
space complexity: O(n)