Maryam's reverse words #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangazoom
reviewed
Sep 26, 2018
| finish = nil | ||
|
|
||
| while current_index < my_words.length | ||
| currently_on_letter = my_words[current_index] != " " |
There was a problem hiding this comment.
i haven't seen this before - is it just returning true or false?
| end | ||
|
|
||
| if start && finish | ||
| reverse_one_word(my_words, start, finish) |
There was a problem hiding this comment.
i like that you split it into different functions - easy to follow
shrutivanw
reviewed
Nov 15, 2018
| first_letter = word[i] | ||
| last_letter = word[index] | ||
|
|
||
| word[i] = last_letter |
There was a problem hiding this comment.
Idea for further improvement: can you swap using only one temporary variable instead of two as you have now?
shrutivanw
reviewed
Nov 15, 2018
| index -= 1 | ||
| end | ||
|
|
||
| return word |
There was a problem hiding this comment.
Since you're reversing in place, you don't need to return word. Line 23 could simply be return
|
Nice work! 👍 I didn't see any comments or description on the time and space complexity. Take a read of the explanations on https://github.com/Ada-C10/reverse_words/blob/solution/lib/reverse_words.rb Slack me if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.