Dionisia - Edges - reverse_sentence #35
Conversation
| @@ -1,4 +1,58 @@ | |||
| # A method to reverse the words in a sentence, in place. | |||
|
|
|||
| # time complexity is O(1) | |||
There was a problem hiding this comment.
The space complexity and it's reasoning is correct. However the time complexity of your algorithm is not O(1). To figure out the time complexity, you want to count the number of steps or the number of operations your algorithm takes in relation to the size of the input. If the input has n characters and you are looking to examine each character, then just to examine each character, you will need n steps. In this case, you want to add up the number of steps taken by word_reverse and reverse_words to compute the time complexity.
|
The algorithm looks good. I added some comments inline for the time and space complexity. Take a look at another similar solution and explanation of the time and space complexity here: https://github.com/Ada-C10/reverse_words/blob/solution/lib/reverse_words.rb Slack me if you'd like to discuss further or have any questions. |
time complexity is O(1)
space complexity is O(1)
Only 2 variables temporarily created to hold the sentence start and end points. Doesn't change based on the input size.