palindrome_ms #39
Open
palindrome_ms #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 26, 2018
|
|
||
| while current_index < my_phrase.length | ||
|
|
||
| if my_phrase[current_index] == " " |
There was a problem hiding this comment.
To account for:
- multiple, consecutive white spaces
- white spaces at both current_index as well as back_index
Consider:
- not having the back_index moving forward not as an elsif but a separate condition.
- converting the white space checking into a loop instead of conditional statements.
shrutivanw
reviewed
Nov 26, 2018
| end | ||
|
|
||
| if my_phrase[current_index] != my_phrase[back_index] && | ||
| # my_phrase[current_index] != " " && |
There was a problem hiding this comment.
I think the suggestions mentioned in the above comment would help address the issue you were seeing here.
|
Your algorithm is on the right track. To get all the test cases passing i.e. making your algorithm complete, consider the suggestions added in the comments inline. Also think about and add a comment to explain and share the time and space complexity of your algorithm. Slack me if you have any questions or would like to sound board more ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.