Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jane's palindrome_check #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion lib/palindrome_check.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,45 @@
# A method to check if the input string is a palindrome.
# Return true if the string is a palindrome. Return false otherwise.
# Time Complexity: O(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always explain what n stands for while explaining your time and space complexity. That along with your explanation for reasoning behind your answer, is the complete answer for the time and space complexity. In this case, n is the number of characters in the input string parameter.

# Space Complexity: O(n)

def string_reverse(my_string)
i = 0
j = my_string.length - 1

while i < j
placeholder = my_string[i]
my_string[i] = my_string[j]
my_string[j] = placeholder
i += 1
j -= 1
end
return my_string
end

def palindrome_check(my_phrase)
raise NotImplementedError
return false if my_phrase.nil?

my_phrase_original= []
my_phrase_reversed = []

i = 0
while i < my_phrase.length
if my_phrase[i] != " "
my_phrase_original << my_phrase[i]
my_phrase_reversed << my_phrase[i]
end
i += 1
end

string_reverse(my_phrase_reversed)

i = 0
while i < my_phrase_original.length
return false if my_phrase_original[i] != my_phrase_reversed[i]
i += 1
end

return true

end