Naheed Edges Palindrome #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 20, 2018
| i = 0 | ||
| j = my_phrase.length - 1 | ||
| while i < j do | ||
| until my_phrase[i] != " " |
There was a problem hiding this comment.
In the two nested inner loops, continue to check and confirm that i is less than j before comparing the character at the index i (or j) with a white space.
|
Nice work! I added a minor comment to make your algorithm further robust. I didn't see any comments on the time and space complexity. Think about what the time and space complexity of your algorithm would be. Friendly reminder: Always explain what n stands for while explaining your time and space complexity. That along with your explanation for reasoning behind your answer, is the complete answer for the time and space complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.