Trang & Daniela - RideShare #5

tfrego · 2018-08-31T22:04:30Z

OO Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	When establishing the Driver Class, we decided to create a new initialize method instead of inheriting the User super class initialize method. We saw in the test file, the User class took a hash argument while the Driver class took keyword arguments. If the tests had not been pre-written, we most likely would've kept it consistent and used super and a hash.
Describe any examples of composition that you encountered in this project, if any	TripDispatcher has drivers, passengers, and trips with a 1 to many relationship. Drivers and Passengers both have trips with a 1 to many relationship. Trips have both passengers and drivers.
Describe the relationship between `User` and `Driver`	Driver is a subclass of User. It inherits the add_trip and total_time_spent methods. It overrides net_expenditures to account for total_revenue.
Describe a nominal test that you wrote for this assignment.	We created many nominal trip cases to calculate the net expenditure for a nominal test. These test cases had trip costs ranging from $5 to $10.
Describe an edge case test that you wrote for this assignment	When testing average rating, we tested an edge case where the driver had 0 trips. This was to ensure that our program did not attempt to divide by zero.
Describe a concept that you/your pair gained more clarity on as you worked on this assignment	We gained more clarity on the syntax of using classes, creating new instances and referring to them in the tests. We became more comfortable assigning and referencing instance variables. We also gained more clarity using Let. We were able to utilize more enumerables and ternary operators.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We felt that we both have the same communication style and that helped us to collaborate. We both got into a groove with our pair programming roles that when one is the driver, the navigator is helping with the correct syntax and methods to invoke, which helped speed up the project.

…_spent methods

…time

…ver is also a user

…new TripDispatcher

…ven_trips arrays. tests passed.

…r who hasnt driven for the longest time. tests passed.

dHelmgren · 2018-09-09T00:24:05Z

Ride Share

What We're Looking For

Feature	Feedback
Baseline
Used Git Regularly	Yes!
Answer comprehension questions	Good examples across the board.
Wave 1
Appropriate use of Ruby's `Date`	Yes!
`Trip` has a helper method to calculate duration	Yes!
`User` (passenger) has a method to calculate total cost of all trips	Indeed!
Tests for wave 1	They look good!
Wave 2
`Driver` inherits from `User`	Yes!
`Driver` has `add_driven_trip` method	Check!
`Driver` has method to calculate average rating	Check!
`Driver` has method to calculate net expenditures and it uses `super`	Check!
`Driver` has a method to calculate total revenue	Check!
Tests for wave 2	Good job covering lots of edge cases!
Wave 3
`TripDispatcher` has a new method to create trips	Yep!
creating a trip in `TripDispatcher` relies on methods in `Driver` and `User` (passenger) to modify their own attributes	They do!
Complex logic was correctly implemented	Thumbs up!
Tests for `request_trip`	Good tests!
Methods from wave 1 and 2 handle incomplete trips	They do!
Tests for wave 1 and 2 methods with incomplete trips	Yep!
Wave 4 (Optional)
`TripDispatcher` now assigns trips to either the newest driver (no trips), or the driver who has not driven in the longest time	Good work here!
Appropriate helper methods were made to help with complex logic	The way that you wrote this doesn't lend itself to further helpers!
Tests for wave 4	GOOD TESTS!
Overall	Nice work across the board. Note that you can spot warnings at the top of the output when you run your rake.

dHelmgren · 2018-09-08T23:59:38Z

lib/trip_dispatcher.rb

+    def request_trip(user_id)
+      available_drivers = @drivers.select {|driver| driver.status == :AVAILABLE and driver.id != user_id }
+
+      driver = available_drivers.find {|driver| driver.driven_trips.empty?}


Check your warnings. It doesn't make a huge amount of difference in THIS code, but here and on line 102, you have a "shadowed variable". driver on the left hand side of this assignment is being covered up by |driver| inside this find, and it creates a situation that is ambiguous to the compiler and ambiguous to a reader

dHelmgren · 2018-09-09T00:03:02Z

specs/trip_spec.rb

      start_time = Time.parse('2015-05-20T12:14:00+00:00')
      end_time = start_time + 25 * 60 # 25 minutes
-      @trip_data = {
+      data = {


This creates a compiler warning too. The way to keep the compiler from complaining is to explicitly return data.

dHelmgren · 2018-09-09T00:04:18Z

lib/trip.rb

@@ -22,5 +26,10 @@ def inspect
      "ID=#{id.inspect} " +
      "PassengerID=#{passenger&.id.inspect}>"
    end
+
+    def trip_duration
+      return @end_time == nil ? nil : duration = @end_time - @start_time


dHelmgren · 2018-09-09T00:06:28Z

lib/user.rb

+
+  end
+
+  class Driver < User


For future's reference, at least while you're still less experienced with Ruby, I'd avoid declaring 2 classes inside the same file. Especially in Ruby, this can hide problems with your code during the testing process.

dHelmgren · 2018-09-09T00:09:59Z

lib/user.rb

+    def total_revenue
+      sum = 0
+
+      @driven_trips.each do |driven_trip|


Don't forget that in Ruby you have access to methods like Sum! I don't always think they're the best choice for every situation, but they can be an effective way to concisely communicate your thinking to readers!

tfrego and others added 30 commits August 27, 2018 15:20

corrected trips_test.csv and outlined net_expenditures and total_time…

48ea89e

…_spent methods

load_trips converts times into Time objects

0dcb270

trip initialize raises ArgumentError if start time is later than end …

43ead54

…time

calculate trip duration and completed tests

fb4aa26

calculates net expenditures for a user

cc7d80b

create total_time_spent method and associated tests

0cb375c

added outlines for new features

a603454

add ArgumentError for invalid ID in driver initialize

845d78f

checks for valid VIN input, create empty driven_trips array

3f53a67

test for bad status

eb1a4db

add argument error for invalid driver status

cb369e4

Merge branch 'master' of https://github.com/tfrego/oo-ride-share

71766c7

create load_drivers and replace passenger with driver instance if dri…

5d70e53

…ver is also a user

find driver. updated tests to include third argument when creating a …

1407316

…new TripDispatcher

stores a driver object for each trip

5b3d0a6

create add_driven_trip method

ce6c971

enabled tests in driver spec

83e9ef5

Merge branch 'master' of https://github.com/tfrego/oo-ride-share

1da101c

update driver_spec tests to driven_trip

aa88c2d

update trip_dispatcher_spec for driver

30cbbcf

Merge branch 'master' of https://github.com/tfrego/oo-ride-share

2676ef2

wrote and tested average_rating method

fa5d16f

wrote and tested Driver.average_rating

25d5961

add total_revenue method for driver

43946e3

wrote and tested net expenditures method

d90eb63

create request_trip method

d85e045

request trip adds the trip to both the passenger.trips and driver.dri…

12e4015

…ven_trips arrays. tests passed.

raise ArgumentError if no drivers are available

3dbdcda

updated old user and trip methods to accommodate in progress trips

46f4c11

modified request_trip to choose the driver with no trips or the drive…

da9ab8f

…r who hasnt driven for the longest time. tests passed.

mystioreo and others added 13 commits August 31, 2018 11:10

added new trips csv to add data for wave 4

6639641

fixed code that checks for the driver with the least recent trip

d13cc32

format data to align

216e930

Merge branch 'master' of https://github.com/tfrego/oo-ride-share

2aa53a8

add more tests for Wave 4

1350433

refactored load users method

7230306

refactored trip_dispatcher.rb

9d724f7

refactor trip.rb

cc05b13

refactor user.rb

e2b7de4

refactored user_spec to use let

1937225

refactored trip_spec to use let

26682f2

refactor driver_spec.rb

e2f73fa

formatted trip_dispatch_spec

d75b2df

Hamled mentioned this pull request Sep 7, 2018

Val & Carly - OO Ride Share - Edges #18

Open

dHelmgren reviewed Sep 9, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trang & Daniela - RideShare #5

Trang & Daniela - RideShare #5

tfrego commented Aug 31, 2018

dHelmgren commented Sep 9, 2018

dHelmgren Sep 8, 2018

dHelmgren Sep 9, 2018

dHelmgren Sep 9, 2018

dHelmgren Sep 9, 2018

dHelmgren Sep 9, 2018

Trang & Daniela - RideShare #5

Are you sure you want to change the base?

Trang & Daniela - RideShare #5

Conversation

tfrego commented Aug 31, 2018

OO Ride Share

Comprehension Questions

dHelmgren commented Sep 9, 2018

Ride Share

What We're Looking For

dHelmgren Sep 8, 2018

Choose a reason for hiding this comment

dHelmgren Sep 9, 2018

Choose a reason for hiding this comment

dHelmgren Sep 9, 2018

Choose a reason for hiding this comment

dHelmgren Sep 9, 2018

Choose a reason for hiding this comment

dHelmgren Sep 9, 2018

Choose a reason for hiding this comment