Sammi Jo & Jazz 00 Ride Share #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ride ShareWhat We're Looking For
|
CheezItMan
reviewed
Sep 7, 2018
| return 0 | ||
| else | ||
| sum = 0 | ||
| @driven_trips.each do |trip| |
There was a problem hiding this comment.
This would need to be adapted to incomplete trips.
complete_trips = @driven_trips.select { |trip| trip.rating != nil }
sum = complete_trips.sum_by { |trip| trip.rating }
return sum.to_f / complete_trips.length| def total_revenue | ||
| sum = 0 | ||
| @driven_trips.each do |trip| | ||
| if trip.cost == nil |
| return revenue = (sum * 0.80) | ||
| end | ||
|
|
||
| def net_expenditures # driver.net_expenditures |
| available = @drivers.find { |driver| | ||
| driver.status == :AVAILABLE && driver.id != user_id | ||
| } | ||
| if available == nil |
There was a problem hiding this comment.
available can't be nil instead you should check to see if available.empty?
| if delay < DELAY_LIMIT | ||
| puts "#{exception.message} Please wait. (current delay @ #{delay}" \ | ||
| " of #{DELAY_LIMIT})" | ||
| sleep(5) |
| driver = RideShare::Driver.new(id: 54, name: "Rogers Bartell IV", | ||
| vin: "1C9EVBRM0YBC564DZ") | ||
| vehicle_id: "1C9EVBRM0YBC564DZ") | ||
| expect(driver.average_rating).must_equal 0 | ||
| end | ||
|
|
||
| it "correctly calculates the average rating" do |
There was a problem hiding this comment.
You also need a test here for handling the average with some incomplete trips.
| expect((dispatcher.find_driver(5).driven_trips).length).must_equal (old_number_of_driven_trips + 1) | ||
| end | ||
|
|
||
| it "correctly handles NO AVILABLE DRIVERS situation" do |
| @@ -59,4 +58,42 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe "net expenditures" do | |||
There was a problem hiding this comment.
You should also test when there are no trips for the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OO Ride Share
Congratulations! You're submitting your assignment!
Comprehension Questions
UserandDriver