oo-ride-share - Liz and Hannah #10

hertweckhr1 · 2018-08-31T23:10:55Z

OO Ride Share

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	When we were working on wave 2, we were originally trying to make our code align with the spec files. We came to the decision to end up changing some of the spec files to fit the requirements, because the spec files were not aligned with changes to the code requirements. We were constantly hit with errors, and realized this was the right to make.
Describe any examples of composition that you encountered in this project, if any	We had a user, class, driver class, and trip dispatcher. A passenger and driver can both have many trips. A trip can only have one passenger and one driver.
Describe the relationship between `User` and `Driver`	Driver is a subclass of User. It inherits attributes from the user class, while also adding attributes of its own like driven_trips and status.
Describe a nominal test that you wrote for this assignment.	We wrote a test to test if it assigns an available driver. It checks to make sure in the event of requesting a trip, the driver id must equal the expected value from the test file.
Describe an edge case test that you wrote for this assignment	An edge case that we wrote, is if there are no available drivers, we then add an argument error.
Describe a concept that you/your pair gained more clarity on as you worked on this assignment
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We realized that the code we're given may not be in perfect form, so it's wrong to make the assumption it is. Through that we learned more about deciphering errors, and editing spec files to help code run successfully. We also learned more about the use of inheritance and object oriented programming. As far as pair feedback - we both thought we knew when to go and ask when we did not understand. On a way to improve, we often had good ideas, but instead with trying one way, we ended up trying many different variations at the same time, and then code often became very confusing. In the future we think it would be beneficial to focus on one idea at a time.

… things pass

…complete

…ps. Tests driver will be unavilabable during drive

…nd time spent plus average rating cannot be completed with in progress trip

…st recent trip

CheezItMan · 2018-09-06T15:11:35Z

Ride Share

What We're Looking For

Feature	Feedback
Baseline
Used Git Regularly	Check, good number of commits and good commit messages, you used branches too!
Answer comprehension questions	Check
Wave 1
Appropriate use of Ruby's `Time`	Check
`Trip` has a helper method to calculate duration	Check
`User` (passenger) has a method to calculate total cost of all trips	Check
Tests for wave 1	Check
Wave 2
`Driver` inherits from `User`	Check
`Driver` has `add_driven_trip` method	Check
`Driver` has method to calculate average rating	Check
`Driver` has method to calculate net expenditures and it uses `super`	Check
`Driver` has a method to calculate total revenue	Check
Tests for wave 2
Wave 3
`TripDispatcher` has a new method to create trips	Check
creating a trip in `TripDispatcher` relies on methods in `Driver` and `User` (passenger) to modify their own attributes	Check
Complex logic was correctly implemented	Check
Tests for `request_trip`	Check
Methods from wave 1 and 2 handle incomplete trips	Check
Tests for wave 1 and 2 methods with incomplete trips	Check
Wave 4 (Optional)
`TripDispatcher` now assigns trips to either the newest driver (no trips), or the driver who has not driven in the longest time	Good logic for determining the driver. You are selecting a driver with no trips or a driver with the oldest trip.
Appropriate helper methods were made to help with complex logic	Yes, although `request_trip` could be broken up further. You do have a great helper method in `Driver`.
Tests for wave 4	Good tests written for `request_trip`.
Overall	You did really well. You have some great tests and solid application code. Great work!

CheezItMan · 2018-09-06T14:59:38Z

lib/trip_dispatcher.rb

+      passenger = find_passenger(user_id)
+
+      available_drivers = @drivers.find_all { |driver| driver.status == :AVAILABLE && driver.id != user_id}
+         raise ArgumentError, 'No available drivers' if available_drivers == []


Minor issue: Shouldn't be indented

CheezItMan · 2018-09-06T15:01:01Z

lib/driver.rb

+
+    def add_trip_in_progress(trip)
+      @status = :UNAVAILABLE
+      @driven_trips << trip


Why not call add_driven_trip instead?

CheezItMan · 2018-09-06T15:01:29Z

lib/driver.rb

+    end
+
+    def net_expenditures
+      return (super - total_revenue)


CheezItMan · 2018-09-06T15:01:59Z

lib/driver.rb

+    end
+
+# latest drive developed for wave 4
+    def latest_drive


Very clever method, you're not assuming the most recent trip is the last one in the array. That's good!

CheezItMan · 2018-09-06T15:08:59Z

lib/trip_dispatcher.rb

+      return @drivers.find { |driver| driver.id == id }
+    end
+
+    def request_trip(user_id)


This method is well done, but it's a bit long. You could break it into some helper methods doing the tasks of:

Selecting an available driver

Creating a new trip

CheezItMan · 2018-09-06T15:11:15Z

specs/user_spec.rb

@@ -58,5 +72,39 @@
        expect(trip.passenger.id).must_equal 9
      end
    end
+
+    it 'calculates the net expenditure of all trips for the user' do


You should also test this with a person with no trips.

hertweckhr1 and others added 20 commits August 27, 2018 15:05

saved with corrected bug

8e9c900

parsed time calculated time duration in seconds and dev'd tests - all…

e2668fa

… things pass

Merge branch 'master' of https://github.com/xLJohnsonx/oo-ride-share

dbe337f

test and method built for net expenditure - passes test

80a1732

Wave 1.2, time spent exception written

9516489

method built to pass total time spent on all trips for user - wave 1 …

dc817e4

…complete

driver class created and passes tests updated driver_spec too

ee00be5

driver instances added to trip.rb, passes test

198d51b

attempt to load drivers with trip dispatcher too many errors

00d71f6

loaded drivers successfully from csv file

7826cf1

Wave 2 load drivers portion complete

dfde8c7

wave 2 complete and tests pass

988846e

Request_trip method added with tests - first draft

2f8884b

combined header at top of trip_request specs

1ac95f3

tested trip_request adds to driver trips, user trips, and overall tri…

d528dd3

…ps. Tests driver will be unavilabable during drive

wave 3 complete all - completed so drivers cannot drive themselves, a…

7beb0e2

…nd time spent plus average rating cannot be completed with in progress trip

added tests for wave 4 and added trip for driver 8 in test data

17c11db

ideas developed for solving wave 4

d06d6da

final cleanup

4787ede

tests and code complete for finding driver with no trips and then lea…

77ca856

…st recent trip

CheezItMan reviewed Sep 6, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

oo-ride-share - Liz and Hannah #10

oo-ride-share - Liz and Hannah #10

hertweckhr1 commented Aug 31, 2018

CheezItMan commented Sep 6, 2018

CheezItMan Sep 6, 2018

CheezItMan Sep 6, 2018

CheezItMan Sep 6, 2018

CheezItMan Sep 6, 2018

CheezItMan Sep 6, 2018

CheezItMan Sep 6, 2018

oo-ride-share - Liz and Hannah #10

Are you sure you want to change the base?

oo-ride-share - Liz and Hannah #10

Conversation

hertweckhr1 commented Aug 31, 2018

OO Ride Share

Comprehension Questions

CheezItMan commented Sep 6, 2018

Ride Share

What We're Looking For

CheezItMan Sep 6, 2018

Choose a reason for hiding this comment

CheezItMan Sep 6, 2018

Choose a reason for hiding this comment

CheezItMan Sep 6, 2018

Choose a reason for hiding this comment

CheezItMan Sep 6, 2018

Choose a reason for hiding this comment

CheezItMan Sep 6, 2018

Choose a reason for hiding this comment

CheezItMan Sep 6, 2018

Choose a reason for hiding this comment