Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dionisia - Edges - exquisite #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

larachan15
Copy link

Exquisite React

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How did this project differ from in-class examples? We had to hide certain components depending on whether or not a user submitted a poem line, or wanted to finalize the poem.
How was this project similar to in-class examples? The way to generate a form was similar, also using props and callback functions.
If you had time to refactor one part of this project, what would you do to make it better? I would probably make the playerSubmissionForm more dynamic? Also, I would add the propTypes to enforce what the child component is expecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant