Kay and Laura.rb #21

lauracodecreations · 2018-08-17T23:26:19Z

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the components that make up a method?	method signature, body block, parameters
What are the advantages of using git when collaboratively working on one code base?	you make sure you are both working on the most updated version of the file.
What kind of relationship did you and your pair have with the unit tests?	we learned how to debug them, create them, and how to use pry with it, and their syntax
Does your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful?	yes, it helped us to more efficiently iterate through the data structure. We used max_by to select max score and .sort_by to sort the strings by length and select, to select the key that matched the value
What was one method you and your pair used to debug code?	pry, and irb
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	how we improved our communication as the days passed, and how we became more efficient presenting and emerging ideas especially using the white board

…tters

…ictionary word, failing test that previously was passed in wave 4--testing merge previously passing code with current buggy code

…ring

CheezItMan · 2018-08-23T18:03:25Z

Adagrams

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	Check
Both teammates contributed to the codebase	I assume so
Small commits with meaningful commit messages	Small commits, for your messages I suggest you avoid mentioning waves and talk about the functionality added.
Code Requirements
`draw_letters` method	Check, but it's a bit awkward. I left some notes in the codebase.
Uses appropriate data structure to store the letter distribution	Well done!
All tests for `draw_letters` pass	Check
`uses_available_letters?` method	Check, but you have some redundant code here. I left notes in the code.
All tests for `uses_available_letters?` pass	Check
`score_word` method	Check
Uses appropriate data structure to store the letter scores	Nice!
All tests for `score_word` pass	Check
`highest_score_from` method	Yes, but you have some inefficiencies here. You loop through the tied words and each time the loop goes, it sorts the list again.
Appropriately handles edge cases for tie-breaking logic	It works.
All tests for `highest_score_from` pass	Check
Overall	Overall you did ok, you had some inefficiencies and need to refactor your code.

CheezItMan · 2018-08-23T17:39:58Z

Kay_and_Laura_adagrams.rb

+def draw_letters
+
+ # all letters
+ letters = %W(a a a a a a a a a b b c c d d d d e e e e e e e e e e e e f f g g g h h i i i i i i i i i j k l l l l m m n n n n n n o o o o o o o o p p q r r r r r r s s s s t t t t t t u u u u v v w w x y y z )


Good data structure to use!

CheezItMan · 2018-08-23T17:41:05Z

Kay_and_Laura_adagrams.rb

+ 10.times do
+   # check if index is in indices_used array , if true generate new random index
+   while indices_used.include?(index)
+     index = Random.rand(min..max)


Just a note, this loop could potentially go a long time. You would do better to remove an element once you've selected it.

CheezItMan · 2018-08-23T17:48:18Z

lib/adagrams.rb

+      result << true
+    else
+      # user used a letter that does not exists
+      result << false


Maybe you should just return false.

CheezItMan · 2018-08-23T17:48:42Z

lib/adagrams.rb

+  input.each_char do |letter|
+    # check if letter exists in letters_in_han
+    if letters_in_hand.include?(letter)
+      result << true


What if a letter appears twice in input, but not in letters_in_hand

CheezItMan · 2018-08-23T17:50:01Z

lib/adagrams.rb

+  end
+  final_results << result.all? { |value| value == true}
+
+  input.each_char do |letter|


This seems to be doing what the above did, but better. Avoid duplication of effort.

CheezItMan · 2018-08-23T17:56:06Z

lib/adagrams.rb

+  group4 = %w(F H V W Y)
+  group5 = %w(J X)
+  group6 = %w(Q Z)
+  word.upcase.each_char do |letter|


CheezItMan · 2018-08-23T17:59:47Z

lib/adagrams.rb

+        score = data.select{ |k, v| k == winner}.values[0]
+        return {:word => winner, :score => score}
+      else # select shortest word and return it as a winner
+        winner = ties_words.sort_by {|x| x.length}.first


You have a loop and inside that you're sorting each iteration. This is a bit inefficient.

kayxn23 and others added 17 commits August 13, 2018 15:45

random letter created

28a0df7

checks for unique index

ecdfa32

method successfully outputs 10 random letters according to pool of le…

f98d05a

…tters

code still has some errors which are indicated in comments

4c7b378

wave 1 and wave 2 passed tests

669c3c3

wave 3 tests passed successfully

a4463ea

successfully passed tests for wave 4

c95c0ac

wave 5 created method to check if input is a valid word in csv file d…

a3cb5ea

…ictionary word, failing test that previously was passed in wave 4--testing merge previously passing code with current buggy code

fixed a bug in wave 4 but there are still 3 failures

152ffd0

updated specs with pry in line

e12a9d9

fixed wave 4, tests pass now

e4f2906

wave 5 fixed

21dddac

wave 5 fixed, was able to loop trough each line and access it as a st…

429a315

…ring

added 2 tests for wave 5 that are passing

7f7b86d

Create Kay_and_Laura_adagrams.rb

9ff15aa

old version

f377795

fixed merge conflict

ffdcf95

CheezItMan reviewed Aug 23, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kay and Laura.rb #21

Kay and Laura.rb #21

lauracodecreations commented Aug 17, 2018

CheezItMan commented Aug 23, 2018

CheezItMan Aug 23, 2018

CheezItMan Aug 23, 2018

CheezItMan Aug 23, 2018

CheezItMan Aug 23, 2018

CheezItMan Aug 23, 2018

CheezItMan Aug 23, 2018

CheezItMan Aug 23, 2018

Kay and Laura.rb #21

Are you sure you want to change the base?

Kay and Laura.rb #21

Conversation

lauracodecreations commented Aug 17, 2018

Adagrams

Comprehension Questions

CheezItMan commented Aug 23, 2018

Adagrams

What We're Looking For

CheezItMan Aug 23, 2018

Choose a reason for hiding this comment

CheezItMan Aug 23, 2018

Choose a reason for hiding this comment

CheezItMan Aug 23, 2018

Choose a reason for hiding this comment

CheezItMan Aug 23, 2018

Choose a reason for hiding this comment

CheezItMan Aug 23, 2018

Choose a reason for hiding this comment

CheezItMan Aug 23, 2018

Choose a reason for hiding this comment

CheezItMan Aug 23, 2018

Choose a reason for hiding this comment