Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication for ComfyUI-Login #1295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yusefes
Copy link

@yusefes yusefes commented Oct 20, 2024

Fixes #1284

Add bearer token support for ComfyUI-Login compatibility.

  • Add bearer parameter to ComfyClient.connect method to accept the token.
  • Modify WebSocket connection URL in ComfyClient.connect to include bearer token in the extra_headers.
  • Update _get and _post methods in ComfyClient to pass the bearer token correctly.

For more details, open the Copilot Workspace session.

Fixes Acly#1284

Add bearer token support for ComfyUI-Login compatibility.

* Add `bearer` parameter to `ComfyClient.connect` method to accept the token.
* Modify WebSocket connection URL in `ComfyClient.connect` to include bearer token in the `extra_headers`.
* Update `_get` and `_post` methods in `ComfyClient` to pass the bearer token correctly.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Acly/krita-ai-diffusion/issues/1284?shareId=XXXX-XXXX-XXXX-XXXX).
@Acly
Copy link
Owner

Acly commented Oct 21, 2024

Can you adapt websocket so it does not send the header if there is no bearer token?

Looks good otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComfyUI-Login Compability / Token Validation
2 participants