Skip to content

Commit

Permalink
Merge pull request #399 from AccessibleForAll/chore/update-packages
Browse files Browse the repository at this point in the history
Chore/update next and remove storybook
  • Loading branch information
EmmaDawsonDev authored Jun 29, 2024
2 parents f5077b9 + 266d619 commit 37999b9
Show file tree
Hide file tree
Showing 22 changed files with 7,243 additions and 30,197 deletions.
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
!.storybook
7 changes: 1 addition & 6 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
{
"extends": [
"next/core-web-vitals",
"prettier",
"plugin:storybook/recommended",
"plugin:@typescript-eslint/recommended"
],
"extends": ["next/core-web-vitals", "prettier", "plugin:@typescript-eslint/recommended"],
"rules": {
"comma-spacing": ["error", { "before": false, "after": true }],
"react/no-unescaped-entities": 0,
Expand Down
18 changes: 0 additions & 18 deletions .storybook/main.js

This file was deleted.

11 changes: 0 additions & 11 deletions .storybook/preview.js

This file was deleted.

5 changes: 0 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ This project is built with Next.JS, Typescript and CSS modules.
Icons - [React Icons Documentation]( https://react-icons.github.io/react-icons)
Code Snippets - [React Syntax Highlighter Documentation](https://github.com/react-syntax-highlighter/react-syntax-highlighter)
Translations - [next-i18next Documentation](https://next.i18next.com/)
Storybook - [Storybook Documentation](https://storybook.js.org/)

## How to contribute

Expand Down Expand Up @@ -45,10 +44,6 @@ Storybook - [Storybook Documentation](https://storybook.js.org/)
```bash
yarn dev
```
If you are making an isolated component and wish to run storybook locally instead of the whole website run this instead of `yarn dev`:
```bash
yarn storybook
```

10. Make your changes
11. Stage your changes:
Expand Down
2 changes: 1 addition & 1 deletion components/ContentTemplates/HeadingsTemplate.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Image from "next/image"
import Image from "next/legacy/image"
import { NavPage } from "../NavPage/NavPage"
import { CodeBlock } from "../CodeBlock/CodeBlock"
import { headingsPageNavigation } from "../../data/pageNavigationLists"
Expand Down
2 changes: 1 addition & 1 deletion components/ContentTemplates/ImagesTemplate.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Image from "next/image"
import Image from "next/legacy/image"
import { NavPage } from "../NavPage/NavPage"
import { CodeBlock } from "../CodeBlock/CodeBlock"
import { imagePageNavigation } from "../../data/pageNavigationLists"
Expand Down
10 changes: 4 additions & 6 deletions components/Footer/Footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ export const Footer = () => {
<div className={styles.footerTop}>
<ul className={styles.footerList}>
<li>
<Link href="/about">
<a className={styles.footerLink}>About the maintainers</a>
<Link href="/about" className={styles.footerLink}>
About the maintainers
</Link>
</li>

Expand All @@ -35,10 +35,8 @@ export const Footer = () => {
</a>
</li>
<li>
<Link href="/">
<a className={styles.footerLink}>
Accessibility Statement - coming soon
</a>
<Link href="/" className={styles.footerLink}>
Accessibility Statement - coming soon
</Link>
</li>
</ul>
Expand Down
11 changes: 5 additions & 6 deletions components/Nav/NavItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,11 @@ export const NavItem = ({
const isLinkActive = activeNavLink === page.href
return (
<li className={`${styles.navListItem} ${isLinkActive ? "active" : ""}`}>
<Link href={page.href}>
<a
onClick={handleNavClick}
aria-current={isLinkActive ? "page" : false}>
{page.name}
</a>
<Link
href={page.href}
onClick={handleNavClick}
aria-current={isLinkActive ? "page" : false}>
{page.name}
</Link>
</li>
)
Expand Down
Loading

0 comments on commit 37999b9

Please sign in to comment.