Provide minimum changes to be compatible with jQuery 4 #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #103
Audit
slick.js
library, checking for items listed in https://blog.jquery.com/2024/02/06/jquery-4-0-0-beta/$.type()
, removed in jQuery 4. The recommended remediation is to replace with the JavaScripttypeof
syntax.push()
,sort()
,splice()
,focus()
, andproxy()
. Each of these were evaluated by a human and determined to be JavaScript implementations, not jQuery..type()
deprecated kenwheeler/slick#4071 and Updates for jQuery 3.0+ and deprecations kenwheeler/slick#4221 . Both of these also flagged$.type()
as the main functional change needed. The other changes proposed there do not appear to be required for jQuery 4 compatibilityTesting methodology
Uncaught TypeError: d.type is not a function
.