-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new test setup #75
Merged
Merged
new test setup #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 88.56% 84.97% -3.60%
==========================================
Files 26 27 +1
Lines 1863 619 -1244
Branches 164 69 -95
==========================================
- Hits 1650 526 -1124
+ Misses 213 91 -122
- Partials 0 2 +2
|
xlc
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously the test setup was a little awkward, that we didn't run an actual server, but use supertest to "run" the server inside the test. So we had to maintain extra utils to adapt how to call the endpoints. Also, since tests are too coupled with server, it would be very hard to extend for more complex e2e tests.
Change
Decoupled server and tests, and now it's a much cleaner setup: it starts a singleton server as usual, with nyc tracker instrumented. So we can run tests normally, and still get the coverage reports.
This should lay a solid ground for bodhi test v2 too.
Note that this setup only works with nyc, and c8 seemed to have some odd compatibility issue.
Test
whole flow seems to work as expected
test coverage dropped a little, since nyc (now) and c8 (before) has different ways of calculating coverage