Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big refactor #86

Merged
merged 22 commits into from
Aug 7, 2023
Merged

Big refactor #86

merged 22 commits into from
Aug 7, 2023

Conversation

xlc
Copy link
Member

@xlc xlc commented Jul 28, 2023

Improve modularization of each component

@xlc xlc marked this pull request as ready for review August 3, 2023 21:52
@xlc xlc requested a review from ermalkaleci August 3, 2023 21:53
ermalkaleci
ermalkaleci approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@ermalkaleci ermalkaleci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eth_config needs update

@xlc
Copy link
Member Author

xlc commented Aug 7, 2023

what eth_config?

@ermalkaleci
Copy link
Collaborator

https://github.com/AcalaNetwork/subway/blob/master/eth_config.yml

@xlc xlc enabled auto-merge (squash) August 7, 2023 23:05
@xlc xlc merged commit 1ef9ec5 into master Aug 7, 2023
1 check passed
@xlc xlc deleted the refactor branch August 7, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermalkaleci ermalkaleci ermalkaleci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xlc @ermalkaleci