Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify tasks on endpoint rotation #109

Merged
merged 2 commits into from
Oct 3, 2023
Merged

notify tasks on endpoint rotation #109

merged 2 commits into from
Oct 3, 2023

Conversation

ermalkaleci
Copy link
Collaborator

No description provided.

@ermalkaleci ermalkaleci requested a review from xlc October 3, 2023 12:54
@ermalkaleci ermalkaleci merged commit ba32a53 into master Oct 3, 2023
1 check passed
@ermalkaleci ermalkaleci deleted the notify-tasks-on-rotation branch October 3, 2023 12:59
@xlc
Copy link
Member

xlc commented Oct 3, 2023

We need some tests.

@xlc xlc mentioned this pull request Oct 3, 2023
Closed
@ermalkaleci
Copy link
Collaborator Author

We need some tests.

This fixes this
https://github.com/AcalaNetwork/subway/pull/109/files#diff-970b9bf7e8a0d91c2858f070d8b553b1a68225723ca77fad18fd6041e46974f0L244

And it's tested here
https://github.com/AcalaNetwork/subway/pull/109/files#diff-970b9bf7e8a0d91c2858f070d8b553b1a68225723ca77fad18fd6041e46974f0R317-R318

Head subscription was hanging around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc Awaiting requested review from xlc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ermalkaleci @xlc