Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to: #1773
the
asset-registry
module could used for not only statemine/statemint assets, but also sibling token(i.e BNC, PHA etc). thus for new sibling token onboard to acala, now we can useregister_foreign_asset
dispatch call ofasset-registry
instead of merge PR to acala code base from parachain team.a side-effect is
asset-registry
useforeign-asset-id
which is number instead ofTokenSymbol
enum, thus in front/dapp we may needTokenSymbol
mapping toforeign-asset-id
, make sure the token mapping is correct.todo list:
FixedRateOfFungible