[feat] Native privy auth #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygaar
reviewed
Oct 10, 2024
| case 'eth_sendTransaction': | ||
| case 'eth_signTransaction': | ||
| // TODO: Implement | ||
| return randomBytes(32).toString('hex'); // fake tx hash |
There was a problem hiding this comment.
What is the implementation going to be here?
There was a problem hiding this comment.
tbd - currently only sendTransaction is exposed via cross app connect, not a signTransaction
This only applies to transactions from the underlying cross connect EOA, not the AGW
| case 'eth_sign': | ||
| throw new Error('eth_sign is unsafe and not supported'); | ||
| case 'personal_sign': { | ||
| console.log(params); |
There was a problem hiding this comment.
Don't need this if you've verified it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
AbstractPrivyProviderunder@abstract-foundation/agw-react/privyThis provider can be used to wrap the application instead of
AbstractWalletProviderif the hosting application is using Privy for their own authentication.Also added is a convenience hook
useAbstractPrivyLoginwhich allows for quick login/link of AGW account on the host applicationPR-Codex overview
This PR focuses on integrating a new
Privywallet connector into theagw-reactpackage, enhancing the login functionality and provider setup for abstract wallet connections.Detailed summary
id: 'xyz.abs.privy'to the abstract wallet connector.AbstractPrivyProvideranduseAbstractPrivyLogininprivy.ts.useLoginWithAbstractto useid.InjectWagmiConnectorfor handling wallet connections.AbstractPrivyProviderfor configuring thePrivyprovider.usePrivyCrossAppProviderfor managing cross-app accounts.package.jsonto include@privy-io/react-authdependency.