Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Chore - Pre-commit" #162

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

mhinkkan
Copy link
Member

@mhinkkan mhinkkan commented Sep 5, 2024

Reverts #160

There seems to be problems regarding permissions. Hence, I revert this PR now.

@mhinkkan mhinkkan merged commit b7efd63 into main Sep 5, 2024
1 check passed
@cusma
Copy link
Contributor

cusma commented Sep 5, 2024

Pre-commit validation checks GH have right permissions. I think the .github/workflows/update_gh-pages.yml needs write permission (instead of read).

I was about to open a PR to fix it.

How should I proceed?

@cusma cusma mentioned this pull request Sep 5, 2024
@mhinkkan mhinkkan deleted the revert-160-chore/pre-commit-yapf branch September 8, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants