Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream the fixes and improvements made by @mcharo #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Upstream the fixes and improvements made by @mcharo #4

wants to merge 5 commits into from

Conversation

AZMCode
Copy link
Owner

@AZMCode AZMCode commented Mar 4, 2022

A list of improvements so far include:

  • A fix for patches in macOS
  • Added support for arm64
  • Initializes submodules in the download phase instead of the installation phase

If I'm missing anything, please do comment.
Also, please do comment on your success of fixing the macOS issues, I don't have the machines to test it.

I'll merge once I get approval from the author.

@AZMCode
Copy link
Owner Author

AZMCode commented Mar 4, 2022

There seems to be an error regarding the patching procedure on Ubuntu.
Should I fork to fix it myself, or should I give you some time to figure that out?

@kamontat
Copy link

I would love to see this merge.

iGEL pushed a commit to pitch-io/asdf-jq that referenced this pull request Feb 1, 2024
@lsanwick
[Feature] Attempt to guess download URL (AZMCode#4)
e1e3c92 
Migrated code from AZMCode#7

Thanks @timdp!

Test Plan:
- [x] Uninstall jq, and then ran `asdf install jq 1.6`, validated that I saw a correct guess and download.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AZMCode @kamontat