Tutorial add remark updated #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a minimum viable implementation of the `remark` command. This implementation meant to be a bridging step between seeing a positive result and doing things the right way. Tests are not implemented because students are not expected to know how to write them yet.
Follow the convention and throw a CommandException instead of returning a CommandResult as the command did not fulfill its intended function. Add RemarkCommandTest that will test that executeUndoableCommand() throws an Exception. Modify AddressBookParser to accept a RemarkCommand. Add new test to AddressBookParserTest, which will test that typing "remark" returns an instance of RemarkCommand.
Modify RemarkCommand to take in an Index and String for remark, and print those two parameters as the error message Modify RemarkCommandTest to test the equals method Add RemarkCommandParser that will know how to parse two arguments, one index and one with prefix 'r/' Add RemarkCommandParserTest that will test different boundary values for RemarkCommandParser. Modify AddressBookParser to use the newly implemented RemarkCommandParser Modify AddressBookParserTest to ensure that what the user input generated the correct command.
Add Remark to model component (copy from Address, remove the regex and rename accordingly). Add test for Remark (to test the equals method). Modify RemarkCommand to now take in a Remark instead of a String.
Add a label to PersonListCard.fxml Add FXML annotation in PersonCard to tie the variable to the actual label.
Add Person#getRemark() Modify PersonBuilder to support Remark. Modify AddCommand to create a Person with a blank Remark. Modify EditCommand to pass Remarks on unchanged. Modify SampleDataUtil to add remarks for the sample data. Add withRemark() to PersonBuilder.
Update tests and test data to use the remark field.
Replace the error message with the actual logic to modify the remarks of a person. Update RemarkCommandTest to test that execute() logic works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.