Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IntelliJ version, initial support for 2024.1 #44

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

ddworak
Copy link
Member

@ddworak ddworak commented Jan 29, 2024

Closes #43

@ghik would you like to take a look? The plugin seems to work fine on newer versions after minor changes, but I'd be very open to some pointers regarding publishing, i.e.:

  1. Should we consider a separate branch for idea24?
  2. What is the intended release process? I can see the pipeline, but it does not seem to have been used in the previous releases. Also, should plugin.xml be manually updated before release?

@ghik
Copy link
Collaborator

ghik commented Jan 29, 2024

  1. Yes, to be consistent with the convention used so far, create idea24 branch
  2. Edit plugin.xml, invoke sbt packagePluginZip and upload manually via plugin site

@ddworak ddworak changed the base branch from idea23 to idea24 January 29, 2024 17:25
@ghik
Copy link
Collaborator

ghik commented Jan 30, 2024

@ddworak FYI I fave no direct access to this repo anymore.

@ddworak
Copy link
Member Author

ddworak commented Jan 30, 2024

@ghik I had limited access as well, this is now fixed for both you and me.

I believe I cannot upload the plugin as you're listed as the sole maintainer on Jetbrains Marketplace. I'm okay with you uploading it if you like, but maybe we should consider some changes to avoid bus factor ;)

@ghik
Copy link
Collaborator

ghik commented Jan 30, 2024

@ddworak that you?
image

@ddworak ddworak requested a review from ghik January 30, 2024 11:00
@ddworak
Copy link
Member Author

ddworak commented Jan 30, 2024

@ghik apparently so
image

@ddworak ddworak merged commit 5379f77 into idea24 Jan 30, 2024
5 checks passed
@ddworak ddworak deleted the update branch January 30, 2024 11:03
@ghik
Copy link
Collaborator

ghik commented Jan 30, 2024

@ddworak I'll do the build and update. In the meantime, I've added you as a developer to the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 2024.1 EAP
2 participants