DA025251 #486
Merged
DA025251 #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atm-quentin
reviewed
Jul 16, 2024
| @@ -257,8 +257,7 @@ public function write_file($object, $outputlangs, $srctemplatepath = '', $hidede | |||
|
|
|||
| if ($conf->facture->dir_output) { | |||
| $object->fetch_thirdparty(); | |||
|
|
|||
| $deja_regle = $object->getSommePaiement((isModEnabled("multicurrency") && $object->multicurrency_tx != 1) ? 1 : 0); | |||
| $deja_regle = $object->getSommePaiement((isModEnabled("multicurrency") && $object->multicurrency_tx != 1) ? 1 : 0, $hasPaiements); | |||
There was a problem hiding this comment.
tu n'as pas initialisé ta variable
atm-quentin
reviewed
Jul 16, 2024
| @@ -290,7 +290,7 @@ public function write_file($object, $outputlangs, $srctemplatepath = '', $hidede | |||
| if ($conf->facture->multidir_output[$conf->entity]) { | |||
| $object->fetch_thirdparty(); | |||
|
|
|||
| $deja_regle = $object->getSommePaiement((isModEnabled("multicurrency") && $object->multicurrency_tx != 1) ? 1 : 0); | |||
| $deja_regle = $object->getSommePaiement((isModEnabled("multicurrency") && $object->multicurrency_tx != 1) ? 1 : 0, $hasPaiements); | |||
There was a problem hiding this comment.
tu n'as pas initialisé ta variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX|Fix #[issue_number Short description]
[Long description]
Non affichage du tableau de paiement sur les pdf facture
Quand on a des lignes de type prélévements négative et positive
Et que le somme des lignes est égal a 0
Avant l'affichage était conditionné par le fait que la somme des lignes de paiement était positive, maintenant on prend aussi en compte le fait qu'il existe bien des lignes pour les afficher sur la PDF.