-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix math utils issue #532
Fix math utils issue #532
Conversation
- upgraded pm and vendor libs - rebuild libs
I upgraded three.js npm package to |
Looks fine - happy to merge if all working as expected. |
Yes, i will do i have done only tests on desktop, i will do on Mobile soon, if all goes fine i will merge it. |
updated GLTFLoader.js to r147 and partially fixed an issue (caused by changes in three.js r150). We can't use the newer because it require to import AR.js in a |
@nickw1 i will make a new release as i think this is an awaited fix. |
@kalwalt I agree - sorry only just seen your update, I see you;ve released anyway which is great. |
What kind of change does this PR introduce?
continue from PR #523
Can it be referenced to an Issue? If so what is the issue # ?
Yes see PR #523 and issue #515
How can we test it?
Test the Aframe and Threejs examples included in the repository, in the console it should print Aframe version 1.3.0 and no errors about MathUtils...
Summary
For more infos refer to the aforementioned issue and PR.
Does this PR introduce a breaking change?
No
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Tested all the aframe examples.
Other information
Todo list:
150
andthree.min.js
,three.js
included in the examples.