Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] spot Controller findBySpotId API endpoint 수정 #95

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[Hotfix] spot Controller findBySpotId API endpoint 수정 #95

merged 1 commit into from
Mar 20, 2024

Conversation

sanggae4133
Copy link
Contributor

@sanggae4133 sanggae4133 commented Mar 20, 2024 •
edited
Loading

✨ PR 유형

어떤 변경 사항이 있나요??

  • 새로운 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
  • 코드 리팩토링
  • 주석 추가 및 수정
  • 문서 수정
  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정
  • 파일 혹은 폴더명 수정
  • 파일 혹은 폴더 삭제

🛠️ 작업내용

Spot Controller findBySpotId API endpoint 수정

📋 추후 진행 상황

📌 리뷰 포인트

✅ Checklist

PR이 다음 요구 사항을 충족하는지 확인해주세요

  • 커밋 메시지 컨벤션에 맞게 작성했습니다
  • 유지-보수를 위해 주석 처리를 잘 작성했습니다

@sanggae4133 sanggae4133 added the 🔥 bug 버그 수정 label Mar 20, 2024
@sanggae4133 sanggae4133 self-assigned this Mar 20, 2024
choeun7
choeun7 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@choeun7 choeun7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 빠르게 머지할까요

Jeongmin39
Jeongmin39 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@Jeongmin39 Jeongmin39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 ~

@sanggae4133 sanggae4133 merged commit bf73fcd into dev Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choeun7 choeun7 choeun7 approved these changes

@Jeongmin39 Jeongmin39 Jeongmin39 approved these changes

@arinming arinming Awaiting requested review from arinming

Assignees

@sanggae4133 sanggae4133

Labels
🔥 bug 버그 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanggae4133 @Jeongmin39 @choeun7