[Feat] Comment 작성, 수정, 삭제 구현 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choeun7
approved these changes
Jan 19, 2024
| import lombok.Data; | ||
|
|
||
| @Data | ||
| public class CommentUpdateReq { |
There was a problem hiding this comment.
CommentUpdateReq 보다 UpdateCommentReq 쪽으로 수정하면 좋을 것 같아요! CommentWriteReq도요!
| @Transactional | ||
| public ResponseEntity<?> writeComment(UserPrincipal userPrincipal, CommentWriteReq commentWriteReq) { | ||
|
|
||
| Optional<Member> optionalMember = memberRepository.findById(userPrincipal.getId()); |
There was a problem hiding this comment.
이 부분도 optionalMember -> memberOptional 쪽으로 수정하면 좋을 것 같습니다:)
arinming
approved these changes
Jan 19, 2024
| }) | ||
| @PostMapping | ||
| public ResponseEntity<?> writeComment( | ||
| @Parameter(description = "AccessToken을 입력해주세요.", required = true) @CurrentUser UserPrincipal userPrincipal, |
There was a problem hiding this comment.
이 부분 중복이 되는 것 같은데 중복 코드 줄일 방법이 있는지 찾아봐도 좋을 것 같아욥!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
어떤 변경 사항이 있나요??
🛠️ 작업내용
Comment 작성, 수정, 삭제 API 구현
📋 추후 진행 상황
위도, 경도 별 Comment 조회 API 구현 중
Store API 구현 예정
📌 리뷰 포인트
빌더를 제대로 사용해서 코드를 구현한 것이 처음이라 다른 분들 코드 참고해서 했습니다
수정이 필요한 부분이 있다면 말씀해 주세요 감사합니다!
✅ Checklist
PR이 다음 요구 사항을 충족하는지 확인해주세요