Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes the geometry type with Z when three dimensions are required #3

Conversation

sersanchus
Copy link

Even when a geometry field is defined as dim '3' the column type was created without Z. This fix solves the problem of generating postgis types with Z (POINTZ, LINESTRINGZ, POLYGONZ ...) when the column is about to be created.

@sersanchus sersanchus force-pushed the fix_geometry_with_dim branch from add2d9a to a9d3add Compare May 14, 2024 08:37
@sersanchus
Copy link
Author

Hi @peluko00 and @miquelalzanillas, could you consider incorporating this branch into your base_geoengine migration?

@miquelalzanillas miquelalzanillas merged commit a2420f1 into APSL:17.0-mig-base_geoengine May 15, 2024
4 checks passed
@miquelalzanillas
Copy link
Member

miquelalzanillas commented May 15, 2024

@sersanchus Para seguir con la conveción OCA, voy a hacer squash de todos los commits en uno sólo ([[MIG] base_geoengine: Migration to 17.0]) y vamos a coautorizarlo contigo.

@miquelalzanillas
Copy link
Member

@sersanchus No recordaba que para coautorizar voy a necesitar tu correo asociado a tu cuenta de Github. Si no quieres dejarlo por aquí, me lo puedes pasar por [email protected] . Gràcies!

@sersanchus
Copy link
Author

Sin problema, mi correo es [email protected]

Buen trabajo con esta migración, si viera más cosas a corregir os envío los PR si os parece bien, y por cierto, se plantea terminar de ajustar el RecordsPanel no?

@sersanchus
Copy link
Author

Hola @miquelalzanillas, ya puestos con lo de coautorizar, ¿podría pedir que me incluyerais también en el fichero CONTRIBUTORS.md de base_geoengine?
Es un módulo que me interesa mucho y la idea sería seguir dándole soporte.

@miquelalzanillas
Copy link
Member

Claro! Disculpa. Añadido!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants