Week4 #8
Week4 #8
Conversation
tunaunnie
requested review from
chattymin,
jihyunniiii,
t1nm1ksun and
angryPodo
|
γ γ μ΄λ²μλ κ³Όμ μνλκ° λ§μ΄ λ―Έν‘νλ€μ... μ°¨μ£Ό λ΄λ‘ μμ§ν λ°μ± & λΉ λ₯Έ 볡ꡬμ λ€μ΄κ°κ² μ΅λλ€π₯Ή |
There was a problem hiding this comment.
DTOμμ±μ΄ λ§€μ° μμΈνλ€μπ λνΌν΄λμ€λ₯Ό λ£μ μ΄μ κ° μλμ? κΆκΈν΄μ!!!
There was a problem hiding this comment.
μλ² μμ²μ΄ μ±κ³΅ν κ²½μ°μ μ€ν¨ν κ²½μ°μ μ¬μ©νλ DTOκ° λΆλ¦¬λμ΄ μλλ°, μλ΅ νμ μ λ νλμ¬μΌ νλ.. λΆκΈ° μ²λ¦¬λ₯Ό νλ κ²λ³΄λ¨ WrapperDTO μμ failedDTOλ successDTOλ₯Ό ν¨κ» λ£μ΄λκ³ λ WrapperDTOλ₯Ό λ°ννλ λ°©μμ΄ λ§λ€κ³ μκ°νμ΄μ! κ·Έλ°λ° ν©μΈ λ μ¬λ―Όλκ» κΌ κ·Έλ κ² νμ§ μμλ λλ€λ λ§μμ λ€μ΄μ (κ·Έλ¦¬κ³ μ΄κ² μ§κΈ μλ¬μ μμΈ κ°μμ π λ°©μμ μμ ν΄λ³Ό μμ μ λλΉ)
| import org.sopt.and.model.dto.signup.RequestCreateUserDto | ||
| import org.sopt.and.model.dto.signup.ResponseCreateUserSuccessDto | ||
| import org.sopt.and.model.dto.signup.ResponseCreateUserWrapperDto | ||
| import retrofit2.Call |
There was a problem hiding this comment.
μ λ μ΄λ²μ λ νΈλ‘ν2λ₯Ό 곡λΆνλ©΄μ Call vs Responseμ λν΄μ μ°Ύμλ΄€μ΄μ.
μ°¨μ΄μ μ νλ² μ°Ύμ보μκ³ λμ€μ μ½λ£¨ν΄ μ μ©μ Responseκ° λ μ΄μ μ΄ μλ€κ³ νλ λ°κΏλ³΄μλκ²λ μ’μ κ² κ°μμ!
| Log.e(TAG, "μ μ λ‘κ·ΈμΈ μλ¬ ${response.code()}") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
λ‘κ·ΈμΈ μ€ν¨μ λν΄ λ μμΈν μλ¬μ²λ¦¬κ° μμΌλ©΄ μ’μ κ² κ°μμ
| } | ||
| } | ||
|
|
||
| fun PasswordValidCheck(password: String): Boolean { |
There was a problem hiding this comment.
μ΄μ λ λ‘κ·ΈμΈ λͺ μΈλ₯Ό 보μλ©΄ 8μ μ΄νλ©΄ λκΈ° λλ¬Έμ μμ μ€λ λ κ² κ°μμ!
| var userNameState = loginViewModel.userNameState.collectAsState().value | ||
| var passwordState = loginViewModel.passwordState.collectAsState().value | ||
| var isUserNameValid = loginViewModel.isUserNameValid.collectAsState().value | ||
| var isPasswordValid = loginViewModel.isPasswordValid.collectAsState().value | ||
| var shouldShowPassword = loginViewModel.shouldShowPassword.collectAsState().value |
There was a problem hiding this comment.
collectAsStateμλ λ¨μ μ΄ νλ μμ΅λλ€.
μ ννλ flowμ λ¨μ μ΄λΌκ³ ν μ μκ² λ€μ.
liveDataμ flowμ μ°¨μ΄μ μ 곡λΆν΄λ³΄μκ³ , collectAsStateWithLifecycleμ μ¬μ©νμλ©΄ μ’μ κ² κ°μ΅λλ€ :)
| //νμ¬ λ‘κ·ΈμΈν ν ν°μΌλ‘ ν μ¬μ©μμ μ·¨λ―Έλ₯Ό λΆλ¬μ€κΈ° μν¨ | ||
| private val userService by lazy { ServicePool.userService } |
There was a problem hiding this comment.
μ΄λ κ² μ μΈνλ κ²κ³Ό viewModelμ μΈμλ‘ μ μΈνλ κ²μ μ°¨μ΄μ μ μ°Ύμ보μλ©΄ μ’μ κ² κ°μμ
There was a problem hiding this comment.
μμ
μ μ΄μ μ£Όμ°¨ κ³Όμ PRλ€ λ¨Έμ§νκ³ μ§νν΄μ£Όμκ³ , μμ° μμ νμλ‘ μΆκ°ν΄μ£ΌμΈμ.
κ³Όμ μ μΆνμ€ λ λ
Έμ
μ μλ κ³Όμ μ μΆ λ°©μ μ λΆ λ°λΌμ£Όμ
μΌ νκ³ κ³Όμ μ μλ κΈ°λ₯ λͺ
μΈ μ λΆ κ΅¬νν΄μ£Όμ
μΌ ν©λλ€.
νμ κ³Όμ λ μ λ§ νμμ μΈ λΆλΆμ΄κ³ μ λλ‘ μ§νλμ§ μμΌλ©΄ μΆν μ±μΌ λ± νμ
μ§νμ΄ μ΄λ €μ°λ μκ° λμ€ λ κΌ μμ λΆνλ릴κ²μ.
νμ κ³Όμ κ° μ λλ‘ μ§νλμ§ μμ μ μ±μΌ μ°Έμ¬κ° μ΄λ €μΈ μ μμ΅λλ€.
| @Serializable | ||
| data class ResponseGetUserWrapperDto( | ||
| @SerialName("success") | ||
| val success: ResponseGetUserSuccessDto, | ||
| @SerialName("failed") | ||
| val failed: ResponseGetUserFailDto | ||
| ) |
There was a problem hiding this comment.
μ΄κ±° μ΄λ° μμΌλ‘ λ§λ€μ΄λ ν΅μ μ μ΄λ£¨μ΄ μ§λμ?
μ±κ³΅μ κ²½μ°μλ successμ λν κ²λ§ μ€ν¨μ κ²½μ°μλ failed λ§ λ΄λ €λ³΄λ΄μ£Όμ΄ μ§λ ¬νκ° μ μ λ κ² κ°μλ° μ λμνλμ?
|
|
||
| @GET("/user/my-hobby") | ||
| fun getMyHobby( | ||
| @Header("token") request: RequestGetUserHobbyDto |
There was a problem hiding this comment.
μ΄λ κ² λ£μ§ μκ³ μΈν°μ ν°λ₯Ό ν΅ν΄ λ£λ λ°©μλ μμΌλ λμ€μ 곡λΆν΄λ³΄μλ©΄ μ’μ κ² κ°μμ!
| } | ||
| } | ||
|
|
||
| override fun onFailure(call: Call<ResponseGetUserWrapperDto>, t: Throwable) { |
There was a problem hiding this comment.
onFailure λΈλμ μ΄λ€ κ²½μ°μ λ€μ΄μ€κ² λ κΉμ?
| @Serializable | ||
| data class LoginScreen( | ||
| val userNameText: String, | ||
| val passwordText: String | ||
| ) |
There was a problem hiding this comment.
μ΄λ¨ λ μ¬μ©λλ μΉκ΅¬μΈκ°μ?
Related issue π
Work Description βοΈ
Screenshot πΈ
Uncompleted Tasks π
To Reviewers π’