Implementation of fatal error handling #85
Conversation
Add support to handle fatal errors for 1P/2P platforms. The application harvests MCA dump and debug log ID dump along with the processor informations (CPUID, PPIN, Microcode , APIC ID etc) and creates a CPER record. The application also registers com.amd.RAS.Configuration interface to allow the user to set/get user configuration properties. Signed-off-by: Abinaya Dhandapani <[email protected]>
abinayaddhandapani
requested review from
ojayanth,
supven01,
rajaganeshr,
srgovard,
modolaty,
mahkurap and
ashok2ku
| @@ -0,0 +1,13 @@ | |||
| Full Description: | |||
There was a problem hiding this comment.
Please add detailed license description , similar to openbmc repos, https://github.com/openbmc/bmcweb/blob/master/LICENSE
|
|
||
| reviewers: | ||
|
|
||
| matches: |
| @@ -0,0 +1,5 @@ | |||
| #AMD BMC RAS | |||
There was a problem hiding this comment.
Provide additiona info , like build , services , and link to design document. etc.
| } | ||
| }, | ||
| { | ||
| "Reset Signal": { |
| { | ||
| "Configuration": [ | ||
| { | ||
| "apmlRetries": { |
There was a problem hiding this comment.
Be consistent in naming convention. change to ApmlRetries
| #include "esmi_rmi.h" | ||
| } | ||
|
|
||
| class InterfaceManager : public RasConfiguration |
There was a problem hiding this comment.
Better to follow openbmc class definition:
Refer https://github.com/openbmc/bios-settings-mgr/blob/master/include/manager.hpp#L41
| /** | ||
| * @brief Harvests information related to a fatal error. | ||
| * | ||
| * @param info The error code or information related to the fatal error. |
There was a problem hiding this comment.
File scope: follow this format. some places , missing this. revisit all definitions. in the file.
@param[in] info -
| * | ||
| * @param info The error code or information related to the fatal error. | ||
| */ | ||
| void harvestFatalError(uint8_t); |
| @@ -0,0 +1,281 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
|
|
||
| try | ||
| { | ||
| std::ifstream jsonFile(CONFIG_FILE); |
There was a problem hiding this comment.
Refer this code for exception handling in catch. https://grok.openbmc.org/xref/openbmc/phosphor-power/pmbus.cpp?r=48781aef#91
Add support to handle fatal errors for 1P/2P platforms. The application harvests MCA dump and debug log ID dump along with the processor informations (CPUID, PPIN, Microcode , APIC ID etc) and creates a CPER record. The application also registers com.amd.RAS.Configuration interface to allow the user to set/get user configuration properties.