Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support validate and update Slurm script. #347

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Support validate and update Slurm script. #347

merged 1 commit into from
Jan 29, 2025

Conversation

mbobrovskyi
Copy link
Collaborator

Fixes / Features

  • Support validate and update Slurm script.

Testing / Documentation

Testing details.

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

@pawloch00 pawloch00 changed the base branch from main to develop January 28, 2025 11:00
@mbobrovskyi mbobrovskyi marked this pull request as ready for review January 28, 2025 13:54
@pawloch00
Copy link
Collaborator

I don't see how code changes are related to Title and description of this PR

@mbobrovskyi
Copy link
Collaborator Author

I don't see how code changes are related to Title and description of this PR

Nothing has changed. All updates are in the kjob part.

@mbobrovskyi mbobrovskyi merged commit f14d7fe into develop Jan 29, 2025
9 checks passed
@mbobrovskyi mbobrovskyi deleted the mbobrovskyi/validate-and-updat-script branch January 29, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawloch00 pawloch00 pawloch00 approved these changes

@Obliviour Obliviour Awaiting requested review from Obliviour Obliviour is a code owner

@44past4 44past4 Awaiting requested review from 44past4 44past4 is a code owner

@sharabiani sharabiani Awaiting requested review from sharabiani sharabiani is a code owner

@BluValor BluValor Awaiting requested review from BluValor BluValor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbobrovskyi @pawloch00