Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libafl-fuzz: separate frida build + cmplog debug #2591

Open
wants to merge 71 commits into
base: main
Choose a base branch
from

Conversation

R9295
Copy link
Collaborator

@R9295 R9295 commented Oct 8, 2024

Try to fix the cmplog issue in this pr too

@R9295 R9295 changed the title libafl-fuzz: separate frida build libafl-fuzz: separate frida build + cmplog debug Oct 8, 2024
@tokatoka
Copy link
Member

tokatoka commented Oct 8, 2024

https://github.com/mxschmitt/action-tmate

use this if you want to connect to their vm

move time_tracker stage to LibAFL
@R9295
Copy link
Collaborator Author

R9295 commented Oct 8, 2024

Since AFL++ runs the timeout again with double the timeout, to confirm if it is actually a timeout, I'll implement that and check if that fixes the CI

libafl/src/stages/mod.rs Outdated Show resolved Hide resolved
libafl/src/stages/stats.rs Outdated Show resolved Hide resolved
libafl/src/stages/stats.rs Outdated Show resolved Hide resolved
libafl/src/stages/stats.rs Outdated Show resolved Hide resolved
@tokatoka
Copy link
Member

tokatoka commented Oct 8, 2024

you can delete old afl_stat.rs

…ecutor

libafl-fuzz: add verify_timeout stage
@R9295 R9295 marked this pull request as draft October 9, 2024 15:56
@R9295
Copy link
Collaborator Author

R9295 commented Oct 9, 2024

Making this into a draft PR cause still a bit WIP

@R9295 R9295 marked this pull request as ready for review October 11, 2024 10:14
@R9295
Copy link
Collaborator Author

R9295 commented Oct 11, 2024

set_timeout and timeout should be #[inline]

@domenukk domenukk marked this pull request as draft October 23, 2024 11:15
@R9295 R9295 marked this pull request as ready for review October 24, 2024 14:13
}
}

impl<E, EM, Z, S> Stage<E, EM, Z> for VerifyTimeoutsStage<E, S>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go in the main lib as well, right? Or is it forkserver specific?

) -> Result<(), Error> {
let mut timeouts = state
.metadata_or_insert_with(TimeoutsToVerify::<<S::Corpus as Corpus>::Input>::new)
.clone();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why clone all inputs here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants