Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13 Update naming conventions and config structure #16

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

charles-turner-1
Copy link
Collaborator

@charles-turner-1 charles-turner-1 commented Jan 21, 2025

  • Restructure how configuration works, with service names being built procedurally from the config.yaml file.
  • Moved functionality to read config, build registry options etc etc off to a separate utils.py file.
  • Updated tests to respect new structure

TODO:

  • Update readme.
  • Field testing.

  procedurally from the config.yaml file.
- Moved functionality to read config, build registry options etc etc off
  to a separate utils.py file.
- Updated tests to respect new structure

TODO:
  - Update readme.
  - Field testing.
@charles-turner-1 charles-turner-1 linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (57b76e0) to head (1617f24).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   82.23%   83.38%   +1.14%     
==========================================
  Files           6        7       +1     
  Lines         304      325      +21     
==========================================
+ Hits          250      271      +21     
  Misses         54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-turner-1 charles-turner-1 merged commit 09bc65b into main Jan 21, 2025
13 checks passed
@charles-turner-1 charles-turner-1 deleted the restructure_config branch January 21, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update naming conventions and config structure
1 participant