Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust, atomized catalog build #316

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

marc-white
Copy link
Collaborator

Resolves #307 .

This PR showcases a cli.build function (the function that executes the command-line catalog-build instruction) that has been:

  • Atomized into discrete helper functions, rather than being one monolithic block;
  • (Partially) hardened against failures, i.e., the failure of a single experiment to be successfully ingested should not bring down the entire build process.

Creating a draft PR in the first instance to trigger E2E testing.

@marc-white marc-white linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 97.67442% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.36%. Comparing base (1740e5d) to head (9851bff).

Files with missing lines Patch % Lines
src/access_nri_intake/cli.py 97.67% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   98.40%   98.36%   -0.04%     
==========================================
  Files          11       11              
  Lines         940      979      +39     
==========================================
+ Hits          925      963      +38     
- Misses         15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Fail-resistant catalog build
1 participant