Style updates #156
Merged
Style updates #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with line numbers in acknowledgements even if nolinenumbers is set.
Update aastex631.cls to produce output that better matches published manuscripts.
|
I am going to finally accept this in advance of v7 being released. Note that we will likely be disabling PRs for v7 bc we do not manage development on GitHub and we have no CI enabled to ensure that open source contributions don't break things more broadly. If we can get a CI and a workflow setup for ensuring the sanctity of the codebase, we will prob start accepting PRs in the future. Thank you. |
This was referenced Jan 27, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on my previous 2 pull requests (#154 and #155) to update the manuscript style for a closer match to the published version. Notably, it fixes an issue with the acknowledgements not being broken up to equalize columns in a 2-column layout.
This resolves #145 and may also address #132.