Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE-680] 파이썬 버전 상한 수정 #7

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

chankoo
Copy link
Contributor

@chankoo chankoo commented Aug 16, 2024

  • 파이썬 디펜던시가 python = ">=3.9 <3.12"인 public-mydata 패키지에서 해당 aws-firehose-handler를 사용하고자 합니다.
  • 테스트 코드는 돌려봤는데, 또 확인할 부분 있으면 말씀주세요!

@chankoo chankoo requested a review from Kirade August 16, 2024 09:47
@chankoo chankoo self-assigned this Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ce3e506) to head (1e25c93).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           28        28           
=========================================
  Hits            28        28           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3e506...1e25c93. Read the comment docs.

@Kirade
Copy link
Member

Kirade commented Aug 16, 2024

public_mydata 패키지 자체에서 직접 firehose 에 로그를 전송하는 구조는 아마 적절하지 않을것 같습니다.
파이썬 라이브러리에서 발생하는 로그들을 장고에서 수집하는 구조를 조금 더 파악해보면 어떨까요?
예를들면 celery 패키지에서도 로그를 찍는데요. 이것을 장고가 선택적으로 수집할 수 있습니다.

@chankoo
Copy link
Contributor Author

chankoo commented Aug 19, 2024

넵 django에서 public_mydata 패키지 로그 수집하도록 수정하겠습니다

@chankoo chankoo merged commit 7cb4206 into master Aug 19, 2024
7 checks passed
@chankoo chankoo deleted the BE-680--allow-python-version-3.11 branch August 19, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants