Add Safe modules configuration #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germartinez
force-pushed
the
cpk-methods
branch
from
54e761d to
d091af1
Compare
cag
reviewed
Sep 29, 2020
src/CPK.ts
Outdated
| } | ||
| const modules = await this.#contract.call('getModules', []) | ||
| const selectedModules = modules.filter( | ||
| (mod: Address) => mod.toLowerCase() === moduleAddress.toLocaleLowerCase() |
There was a problem hiding this comment.
An address is a string, so just toLowerCase() should be fine? I don't think there's a difference though.
There was a problem hiding this comment.
Good catch! It was the VSCode autocomplete. Thank you!
src/CPK.ts
Outdated
| const sendOptions = normalizeGasLimit({ ...options, from: ownerAccount }) | ||
| const txResult = await this.#contract.send('enableModule', [moduleAddress], { | ||
| ...sendOptions, | ||
| from: ownerAccount |
There was a problem hiding this comment.
I think enableModule follows the rule for SelfAuthorized:
require(msg.sender == address(this), "Method can only be called from this contract");
So essentially you would use execTransaction to call it.
There was a problem hiding this comment.
Yes, I'm updating this and pushing the tests :)
germartinez
force-pushed
the
cpk-methods
branch
2 times, most recently
from
1a2ef4c to
363b040
Compare
rmeissner
approved these changes
Oct 1, 2020
rmeissner
reviewed
Oct 1, 2020
| return await this.#contract.call('getModules', []) | ||
| } | ||
|
|
||
| async isModuleEnabled(moduleAddress: Address): Promise<boolean> { |
There was a problem hiding this comment.
1.2.0 has a contract method for this ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check #89
The following methods won't be added for now until the new CPKFactory contract is available:
cpk.transfer(destination, amountInWei)execTransactions:cpk.execTransactions(txs, {value})