Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(example): convert toc link to locator to fix navigation issues #37

Merged
merged 1 commit into from
Jun 12, 2023
Merged

chore(example): convert toc link to locator to fix navigation issues #37

merged 1 commit into from
Jun 12, 2023

Conversation

adesege
Copy link
Contributor

@adesege adesege commented Jun 12, 2023

Fixes #36

@adesege adesege mentioned this pull request Jun 12, 2023
Closed
@jspizziri jspizziri changed the title convert toc link to locator to fix navigation issues chore(example): convert toc link to locator to fix navigation issues Jun 12, 2023
@jspizziri
Copy link
Contributor

@adesege thanks! Could you please update your commit message to reflect the title of the PR (just updated it). Thanks!

@adesege
Copy link
Contributor Author

adesege commented Jun 12, 2023

Done. We should probably configure commit linting to enforce that in future

@jspizziri jspizziri merged commit 1d3257e into 5-stones:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspizziri jspizziri jspizziri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example app: Unable to navigate using table of contents
2 participants
@adesege @jspizziri