docs: Improve clarity for Radix and complete AVL docs #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeoshuheng
reviewed
Feb 9, 2024
| @@ -372,6 +372,10 @@ private T successor(Node<T> node) { | |||
| return null; | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Should we add this to all the current implementations (eg. segment portions of code based on it's purpose) for consistency?
| // Bit masking here to extract each segment from the integer. | ||
| int mask = ((1 << NUM_BITS) - 1) << (segment * NUM_BITS); | ||
| return (num & mask) >> (segment * NUM_BITS); | ||
| // bit masking here to extract each segment from the integer. |
There was a problem hiding this comment.
Actually I've been thinking - for students taking CS2040S, they have probably not touched CS2100 yet, so the concept of bit representation might be a bit complex for them.
Would it be better to maybe insert more helpful links regarding how computers represent numbers (eg. float, integer).
Maybe we could add this link: https://cheever.domains.swarthmore.edu/Ref/BinaryMath/NumSys.html or somethign else to help clarify things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.