Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#123 market api #134

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Feat/#123 market api #134

merged 6 commits into from
Sep 6, 2023

Conversation

KIM-JUHYEON-79
Copy link

🀨 Motivation

πŸ”‘ Key Changes

  • μƒν’ˆ μƒνƒœ κ΄€λ ¨ μ˜μ–΄/ν•œκ΅­μ–΄ ν•¨μˆ˜ 및 μƒνƒœ 넀이밍 였λ₯˜ ν•΄κ²°
  • λŒ“κΈ€ μƒμ„±μ‹œ μ‹€μ‹œκ°„ 생성 μ•ˆλ˜λŠ” 였λ₯˜ ν•΄κ²°

πŸ™ To Reviewers

  • API μš”μ²­μ½”λ“œμ—μ„œ κ°’μœΌλ‘œ 선언해놓고 return값을 return message라고 ν•΄λ†”μ„œ 였λ₯˜κ°€ λ‚¬λ˜κ±°μ˜€μŠ΅λ‹ˆλ‹€..

@KIM-JUHYEON-79 KIM-JUHYEON-79 self-assigned this Sep 6, 2023
if(_newComment != ''){
if(isNestedComments){
marketcommentProvider.addNestedMarketComment(_newComment, parentsCommentId, widget.marketBoard.articleId!);
//μ—¬κΈ° νŽ˜μ΄μ§€ μž¬λ‘œλ“œν•˜λŠ”κ±°λ‚˜ marketcommentprovider μž¬λ‘œλ“œλ₯Ό λ„£μ–΄μ•Όν• κ±°κ°™μ•„
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λŒ“κΈ€μ„ ν”„λ‘œλ°”μ΄λ”λ‘œ κ΄€λ¦¬ν•˜λŠ” 거라면, getMarketComments λ₯Ό ν•œ 번 더 ν˜ΈμΆœν•˜λŠ” 건 μ–΄λ–€κ°€μš”?

@urlotus urlotus merged commit cd35d88 into develop Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants